PEDS-1490 - updated filter mode and guppy queries#668
Open
skyzhangty wants to merge 1 commit intopcdc_devfrom
Open
PEDS-1490 - updated filter mode and guppy queries#668skyzhangty wants to merge 1 commit intopcdc_devfrom
skyzhangty wants to merge 1 commit intopcdc_devfrom
Conversation
grugna
approved these changes
Oct 14, 2025
Collaborator
|
This looks good to me. @paulmurdoch19 could you take a second look at it? Specially the function used by the amanuensis jobs to fix and check the saved searches / filterset. WARNING! Do not merge until uc-cdis/guppy#331 is merged. |
|
This looks good. WARNING! when this is ready to be merged we need to create a migration in amanuensis to update all the filter-sets and update the validation job to use this new formating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.