feat: added a new “window” property, so that Impetus can be applied to child iframes#32
Open
azaslavsky wants to merge 1 commit intochrisbateman:masterfrom
Open
feat: added a new “window” property, so that Impetus can be applied to child iframes#32azaslavsky wants to merge 1 commit intochrisbateman:masterfrom
azaslavsky wants to merge 1 commit intochrisbateman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I create a child
<iframe>on my page, and want to use impetus in that iframe, that is currently not possible. This commit adds support for the optional "window" property, which allows me to supply a different window to bind impetus to (ex:window: myIframe.contentWindw). I also moved the safari bug fix inside of theinit()function, so that each window that impetus is used with can have this bugfix applied.