[Delivery mode fix] Use the fix version of the RabbitMQ adaptor#78
Merged
mexskican merged 3 commits intoblockchain-interfacefrom Feb 14, 2020
Merged
[Delivery mode fix] Use the fix version of the RabbitMQ adaptor#78mexskican merged 3 commits intoblockchain-interfacefrom
mexskican merged 3 commits intoblockchain-interfacefrom
Conversation
robot-head
reviewed
Feb 13, 2020
| @@ -290,7 +290,10 @@ fn publish_new_block( | |||
| handle_fatal_error(err); | |||
| }) | |||
| .timeout(Duration::from_secs(10)) | |||
Contributor
There was a problem hiding this comment.
did we want to keep the timeouts?
Contributor
Author
There was a problem hiding this comment.
Yes we will keep it for now, to be removed eventually.
Contributor
There was a problem hiding this comment.
this is the version as released in 1.0.4
see #73 for timeouts, it's not QAed yet
ahaensler
approved these changes
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the delivery mode fix into
blockchain-interface