Add support for security policies in resource directory#259
Open
pulsastrix wants to merge 2 commits intochrysn:masterfrom
Open
Add support for security policies in resource directory#259pulsastrix wants to merge 2 commits intochrysn:masterfrom
pulsastrix wants to merge 2 commits intochrysn:masterfrom
Conversation
81e1669 to
0fe5ab6
Compare
This allows users of the resource directory implementation to define policies policies, i.e. limit access to specific endpoint names and sectors. The configuration happens using a separate JSON file that needs to be provided with the `--security-policy` command line option. The file format is currently described in the rd.py module description, a CDDL description (like in credentials.cddl) is not included yet.
0fe5ab6 to
68e44b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the current resource directory implementation in
aiocoap/cli/rd.pywith basic support for security policies, making it possible to restrict access to specific endpoints, which can be useful for a number of use cases:The configuration happens using a separate JSON file that needs to be provided with the
--security-policycommand line option.The file format is currently described in the rd.py module description, a CDDL description (like in credentials.cddl) is
not included yet (but should be added before merging).included inaiocoap/cli/securitypolicy.cddl.This is my first pull request to this repository, I am open to feedback if there is anything I can improve.