You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I prefer to use this tool via Docker for historical reasons. (conflicting PHP versions etc.)
Docker support would also make this tool interesting for devs that don't use PHP.
If you push this to Docker Hub, installation is quite simple:
# e.g. ~/.zprofilechangelogger () {
docker run --rm -it -v $(PWD):/app churchtools/changelogger changelogger $@
}
In this case I suggest updating the README.md as follows:
...
or run via docker.
# e.g. ~/.profilechangelogger () {
docker run --rm -it -v $(PWD):/app churchtools/changelogger changelogger $@
}
first of all thx for this PR. I use docker, but I'm not a pro in this field.
No worries; thank you for looking into this PR nonetheless.
I see more and more packages using githubs registry. Why using Hub instead?
I think it doesn't really matter where the image is being published.
If you don't publish the image you can merge this as is.
If you publish the image to GitHub registry or Docker Hub it would make sense to update:
It's not a strict requirement to publish the image though.
I executed the steps described in the README.md file.
Since then I've been using the local built docker image.
However, it's obviously much more convenient if theres a pre-built image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I prefer to use this tool via Docker for historical reasons. (conflicting PHP versions etc.)
Docker support would also make this tool interesting for devs that don't use PHP.
If you push this to Docker Hub, installation is quite simple:
In this case I suggest updating the README.md as follows:
...
or run via docker.