Skip to content

Docker Support#87

Open
hettiger wants to merge 3 commits intochurchtools:masterfrom
hettiger:docker
Open

Docker Support#87
hettiger wants to merge 3 commits intochurchtools:masterfrom
hettiger:docker

Conversation

@hettiger
Copy link
Contributor

@hettiger hettiger commented Mar 8, 2025

I prefer to use this tool via Docker for historical reasons. (conflicting PHP versions etc.)
Docker support would also make this tool interesting for devs that don't use PHP.
If you push this to Docker Hub, installation is quite simple:

# e.g. ~/.zprofile
changelogger () {
  docker run --rm -it -v $(PWD):/app churchtools/changelogger changelogger $@
}

In this case I suggest updating the README.md as follows:

...
or run via docker.

# e.g. ~/.profile
changelogger () {
  docker run --rm -it -v $(PWD):/app churchtools/changelogger changelogger $@
}

@obstschale
Copy link
Member

first of all thx for this PR. I use docker, but I'm not a pro in this field.

I see more and more packages using githubs registry. Why using Hub instead?

@hettiger
Copy link
Contributor Author

first of all thx for this PR. I use docker, but I'm not a pro in this field.

No worries; thank you for looking into this PR nonetheless.

I see more and more packages using githubs registry. Why using Hub instead?

I think it doesn't really matter where the image is being published.
If you don't publish the image you can merge this as is.
If you publish the image to GitHub registry or Docker Hub it would make sense to update:

  • README.md
  • composer.json script "docker:build": "docker build -t churchtools/changelogger ."

It's not a strict requirement to publish the image though.

I executed the steps described in the README.md file.
Since then I've been using the local built docker image.

However, it's obviously much more convenient if theres a pre-built image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants