Open
Conversation
…red adding embedding dependency to request
…ssy and often requires a LM repair attempt
tendau
requested changes
Sep 5, 2024
Collaborator
tendau
left a comment
There was a problem hiding this comment.
We cannot bring the GC specific UI into main. This either needs to live with the GC branch (deployment) or be pulled out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DynamicFormOrchestrator should be now in a working state for profile gen, which uses the "conversation_without_data" method. The "conversation_with_data" is in a working state, but I added TODO comments on possible improvements for the future if we want to build it out further.
Changes :
Some features to point out that are NOT implemented, due to time constraint and priority: