Conversation
|
In principle I think this makes sense, but I would suggest linking any issues/PRs/participation in Cilium (and ztunnel upstream if applicable) for all requested members first to demonstrate the active involvement in this area. I would like to see direct participation from each person demonstrating they have read the reviewer responsibilities and understand the expectations around contributing collaboratively and in a vendor-independent manner. To some degree given this is a new area of focus for the Cilium organization, the "prior contributions" aspect can be waived. For the temporary development branch of github.com/cilium/ztunnel I'd expect this group to collectively figure out what process makes sense for contributions. That said I do want to ensure that any new contributors to this area are operating under the same assumptions as other contributors, members and reviewers. It would also help to see an endorsement from existing committers who intend to help steer this effort. I personally won't have much time to spend in this area, so I'll be looking to other reviewers & committers to help share the load. (cc @hemanthmalla @ldelossa @rgo3 ) Other than that, I think this is an exciting area for the project to move in so I hope this is a positive step forward for collaborating together :) Note the linter failure is reporting that none of the proposed contributors are existing members of the organization. The immediate linter issue can be resolved by calling |
|
cc @cilium/ztunnel @cilium/committers |
|
@joestringer sounds fair. For upstream other than a small unit test in istio ztunnel, I have the SPIRE PR in flight. I am working with the Spire community to get the Broker Endpoint API squared away and implemented into spire. That will then be used to replace the existing delegated identity api with a spiffe supported api. |
dc19d4c to
1b102c6
Compare
hemanthmalla
left a comment
There was a problem hiding this comment.
@nddq @MikeZappa87 Thanks for stepping up to help maintain this. Do you mind also updating the description to include all PRs including inflight to main and feature branches for posterity ? Let's also include prior zTunnel work from @MikeZappa87
Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
1b102c6 to
54551f2
Compare
|
@hemanthmalla I've updated the description with a list of PRs from both of us |
|
@nddq @MikeZappa87 can you confirm you've read and agree with the reviewer expectations for the scope of the ztunnel area? |
|
@joestringer I confirmed |
ACK'ing this (confirm) |
ldelossa
left a comment
There was a problem hiding this comment.
Approved. Excited to see further development here!
Add @nddq, @MikeZappa87 as maintainers for the ztunnel repository. The ztunnel repo is a fork of a non-Cilium component and the Microsoft team has the relevant ztunnel and SPIRE domain expertise to review and merge PRs.
The community team has confirmed they are open to expediting org membership into the ztunnel group for all new members.
@MikeZappa87 ztunnel and SPIRE integration PR:
istio/ztunnel#1676
@nddq Cilium PRs:
cilium/cilium#44136
cilium/cilium#44275
cilium/cilium#42160
cilium/cilium#42122
cilium/cilium#43763
cilium/cilium#43229
cilium/cilium#43128
cilium/cilium#41944
cilium/cilium#42364 (collaborated with @rgo3 )
cilium/cilium#43227