Refactor showBusy method for loader class handling #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor showBusy method to ensure loader class management is handled correctly.
makermelissa
approved these changes
Jan 24, 2026
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Great idea using try/finally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor showBusy method to ensure loader class management is handled correctly.
When coding on an ESP32-S3 and trying to create a new folder, a 409 conflict is returned causing a ProtocolError to be thrown.
When this happens, the loading icon never disappears nor is the underlying error shown.