Do not dynamically load tenant model specified in autoload.#228
Open
alpaca-tc wants to merge 2 commits intocitusdata:masterfrom
Open
Do not dynamically load tenant model specified in autoload.#228alpaca-tc wants to merge 2 commits intocitusdata:masterfrom
alpaca-tc wants to merge 2 commits intocitusdata:masterfrom
Conversation
The basic way of Rails is that application code in the development environment is lazy loaded. For this reason, `class_name` is passed as a string rather than a class in the reflection definition, and the string is not constantized until it is evaluated. This is done to reduce performance issues and the complex locking load of constant-loading logic. Now activerecord-multitenant is loading the class specified in the argument to multi_tenant() without lazy loading. This conditional statement was added at citusdata#6, but I have been fixed. Note that for projects where the tenant model does not exist, the existing behavior is supported by specifying `skip_reflection: true`.
alpaca-tc
commented
Jan 18, 2024
| else | ||
| tenant_name.to_s.classify | ||
| end | ||
| !!class_name.safe_constantize |
Contributor
Author
There was a problem hiding this comment.
The class was dynamically loaded in this line.
Although top-level model can be checked with const_defined?(:X) or autoload?(:X), it is difficult for nested models such as A::B::Tenant, so I gave up the method of checking by the presence or absence of a class.
Contributor
Author
|
Ruby can potentially cause deadlocks when loading code with multi-threading. Part of the reason for this was that the gem was making constant load to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic policy of Rails is that application code in the development environment is lazy loaded.
For this reason,
class_nameis passed as a string rather than a class in the reflection definition, and the string is not constantized until it is evaluated.This is done to reduce performance issues and the complex locking load of constant-loading logic.
Now activerecord-multitenant is loading the class specified in the argument to multi_tenant() without lazy loading.
This conditional statement was added at #6, but I have been fixed.
Note that for projects where the tenant model does not exist, the existing behavior is supported by specifying
skip_reflection: true.