Replace Alias Method Chain With Prepend for SchemaDumper#245
Open
rience wants to merge 2 commits intocitusdata:masterfrom
Open
Replace Alias Method Chain With Prepend for SchemaDumper#245rience wants to merge 2 commits intocitusdata:masterfrom
rience wants to merge 2 commits intocitusdata:masterfrom
Conversation
|
@rience please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Contributor
|
@gurkanindibay Could this be merged and released, please? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our application we use this gem and
strong_migrationsthat is using prepend method of adding functionality toActiveRecord::SchemaDumper. Because this one is using alias method chaining - we were hit with stack overflow error when this gem was callingstrong_migrationsand it was then calling initializer which ended up calling this gem again. This PR changes monkey patching approach to use prepend.