Refactor tenant enforcement to use Arel visitor pattern#283
Open
a5-stable wants to merge 1 commit intocitusdata:masterfrom
Open
Refactor tenant enforcement to use Arel visitor pattern#283a5-stable wants to merge 1 commit intocitusdata:masterfrom
a5-stable wants to merge 1 commit intocitusdata:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
#223 attempted to fix an issue where delete_all and update_all with LIMIT would generate subqueries missing the tenant condition in the outer query.
However, this approach has some problems:
Cannot handle edge cases
The implementation cannot properly handle certain scenarios, as reported in #269, #282
Generates unnecessary subqueries
Subqueries are added even when they are not needed:
What I did here
Instead of overriding update_all or delete_all methods, this PR patches prepare_update_statement in Arel::Visitors::ToSql.
This method decides whether a subquery is needed. By hooking here, we can add tenant conditions only when Rails actually creates a subquery, and let Rails handle all the subquery logic itself.