Java svm uses faster Math.pow instead of powi#109
Open
Druid-of-Luhn wants to merge 1 commit intocjlin1:masterfrom
Druid-of-Luhn:master
Open
Java svm uses faster Math.pow instead of powi#109Druid-of-Luhn wants to merge 1 commit intocjlin1:masterfrom Druid-of-Luhn:master
Math.pow instead of powi#109Druid-of-Luhn wants to merge 1 commit intocjlin1:masterfrom
Druid-of-Luhn:master
Conversation
Using the built-in Math.pow method instead of svm's custom powi. This makes the code faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the built-in
Math.powmethod instead of svm's custompowi. This makes the code faster.I checked this by sampling svm prediction with
jvisualvm.powiused to take about 8-10% of the CPU time (withKernel.dottaking 66-73%). After changing it toMath.powthe time it takes is negligible.