fix: correct flag handling and add version/help options #4
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gh pr merge flags were passed as a single string due to IFS being set to newline+tab only. Fixed by explicitly using space as delimiter when splitting flags into array. Added --help/-h and --version/-V argument handling. Version is injected by `just build` from the VERSION file, replacing the (development) placeholder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gh pr merge flags were passed as a single string due to IFS being
set to newline+tab only. Fixed by explicitly using space as delimiter
when splitting flags into array.
Added --help/-h and --version/-V argument handling. Version is injected
by
just buildfrom the VERSION file, replacing the (development)placeholder.