fix: improve check polling reliability #8
Merged
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 3s initial delay and 10s grace period for CI checks to register before concluding "no checks configured". Previously the script would immediately merge if statusCheckRollup was empty on first poll. Fix skipped checks blocking merge indefinitely. Changed completion condition from SUCCESS==TOTAL to FAILED==0, so skipped/neutral checks no longer prevent merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3s initial delay and 10s grace period for CI checks to register
before concluding "no checks configured". Previously the script would
immediately merge if statusCheckRollup was empty on first poll.
Fix skipped checks blocking merge indefinitely. Changed completion
condition from SUCCESS==TOTAL to FAILED==0, so skipped/neutral checks
no longer prevent merge.