Fixes #10 by xaviermarchegay · Pull Request #11 · cleverage/cache-process-bundle

xaviermarchegay · 2025-12-08T12:34:22Z

upgrade composer.json
Dockerfile (opcache is part of php now)
upgrade versions in github actions

Description

Upgrades php and symfony

Requirements

Documentation updates
- Reference
- Changelog
Unit tests

* upgrade composer.json * Dockerfile (opcache is part of php now) * upgrade versions in github actions

njoubert-cleverage · 2025-12-08T13:05:09Z

.github/workflows/quality.yml

@xaviermarchegay .github/workflows/test.yml must be updated too.

njoubert-cleverage · 2025-12-08T13:08:31Z

Please upgrade Rector & php-cs-fixer config too.

* upgrade test.yml * upgrade minimum php version in composer.json * add parallel run in phpcsfixer * remove @PHP71Migration in phpcsfixer * upgrade php version in rector

* fix test.yml

* remove php8.5

* upgrade phpunit configuration file

njoubert-cleverage · 2025-12-08T14:18:17Z

.github/workflows/test.yml

-
+            symfony-require: 7.4.*
+            variant: symfony/symfony:"7.4.*"
+#          - php-version: '8.4'


uncomment it

njoubert-cleverage · 2025-12-08T14:18:49Z

.github/workflows/test.yml

+#            allowed-to-fail: false
+#            symfony-require: 8.0.*
+#            variant: symfony/symfony:"8.0.*"
+          - php-version: '8.5'


Add - php-version: '8.5'
dependencies: highest
allowed-to-fail: false
symfony-require: 6.4.*
variant: symfony/symfony:"6.4.*"

njoubert-cleverage · 2025-12-08T14:19:03Z

.github/workflows/test.yml

+            allowed-to-fail: false
+            symfony-require: 7.4.*
+            variant: symfony/symfony:"7.4.*"
+#          - php-version: '8.5'


uncomment it

njoubert-cleverage · 2025-12-08T14:19:50Z

.php-cs-fixer.dist.php

    EOF;

 return (new PhpCsFixer\Config())
+    ->setParallelConfig(PhpCsFixer\Runner\Parallel\ParallelConfigFactory::detect())


njoubert-cleverage · 2025-12-08T14:20:58Z

.github/workflows/test.yml

+#          - php-version: '8.4'
+#            dependencies: highest
+#            allowed-to-fail: false
+#            symfony-require: 8.0.*


Try symfony-require: 8.*
variant: symfony/symfony:"8.*"

njoubert-cleverage · 2025-12-08T14:23:01Z

rector.php

+    // here we can define what prepared sets of rules will be applied
    ->withPreparedSets(deadCode: true, codeQuality: true, symfonyCodeQuality: true)
    ->withAttributesSets(symfony: true)
+    ->withComposerBased(symfony: true)


This doesn't work on vendors because symfony version is multiple.

* Remove `withComposerBased` from Rector config * Simplify `.php-cs-fixer.dist.php` by removing `setParallelConfig` * Update `symfony/cache` constraint in `composer.json` * Revise GitHub Actions workflow to add support for PHP 8.4 and 8.5 * Update CHANGELOG for v2.0 release

…` and update CHANGELOG

njoubert-cleverage · 2025-12-09T10:38:26Z

composer.json

    "require": {
        "php": ">=8.2",
-        "cleverage/process-bundle": "^4.0",
+        "cleverage/process-bundle": "^4.0|^5.0",


Only latest version of PB is supported. => "cleverage/process-bundle": "^5.0",

njoubert-cleverage · 2025-12-09T10:39:16Z

CHANGELOG.md


 ### Changes
-* [#10](https://github.com/cleverage/cache-process-bundle/issues/10) Add support for PHP 8.5 and Symfony 8.* Update phpunit/phpunit to version >10.0
+* [#10](https://github.com/cleverage/cache-process-bundle/issues/10) Add support for PHP 8.5 and Symfony 8.* Update phpunit/phpunit to version >10.0 Add support for cleverage/process-bundle ^5.0


Add support for cleverage/process-bundle ^5.0 => Bump version to cleverage/process-bundle ^5.0

… only and adjust CHANGELOG accordingly

…prove readability

Fixes #10

0a97f13

* upgrade composer.json * Dockerfile (opcache is part of php now) * upgrade versions in github actions

xaviermarchegay requested a review from njoubert-cleverage December 8, 2025 12:34

xaviermarchegay assigned njoubert-cleverage Dec 8, 2025

njoubert-cleverage reviewed Dec 8, 2025

View reviewed changes

.github/workflows/quality.yml

Copy link

Member

njoubert-cleverage Dec 8, 2025 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xaviermarchegay .github/workflows/test.yml must be updated too.

xaviermarchegay added 5 commits December 8, 2025 14:29

Fixes #10

5585b5a

* upgrade test.yml * upgrade minimum php version in composer.json * add parallel run in phpcsfixer * remove @PHP71Migration in phpcsfixer * upgrade php version in rector

Fixes #10

7fdd0d8

* fix test.yml

Fixes #10

43102fe

* remove php8.5

Fixes #10

81ec44f

* upgrade phpunit configuration file

Fixes #10

586c8c7

* upgrade phpunit configuration file

njoubert-cleverage reviewed Dec 8, 2025

View reviewed changes

xaviermarchegay added 2 commits December 9, 2025 11:32

#10

6720409

* Remove `withComposerBased` from Rector config * Simplify `.php-cs-fixer.dist.php` by removing `setParallelConfig` * Update `symfony/cache` constraint in `composer.json` * Revise GitHub Actions workflow to add support for PHP 8.4 and 8.5 * Update CHANGELOG for v2.0 release

#10 Add support for cleverage/process-bundle ^5.0 in `composer.json…

847b16f

…` and update CHANGELOG

njoubert-cleverage reviewed Dec 9, 2025

View reviewed changes

xaviermarchegay added 2 commits December 9, 2025 11:47

#10 Update composer.json to require cleverage/process-bundle ^5.0…

749bc02

… only and adjust CHANGELOG accordingly

#10 Update symfony/cache constraint syntax in composer.json to im…

f07924a

…prove readability

njoubert-cleverage merged commit 24e3123 into main Dec 9, 2025
17 of 34 checks passed

njoubert-cleverage deleted the feature/upgrade-sf-php branch December 9, 2025 15:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #10#11

Fixes #10#11
njoubert-cleverage merged 10 commits intomainfrom
feature/upgrade-sf-php

xaviermarchegay commented Dec 8, 2025

Uh oh!

njoubert-cleverage Dec 8, 2025 •

edited

Loading

Uh oh!

njoubert-cleverage commented Dec 8, 2025

Uh oh!

njoubert-cleverage Dec 8, 2025

Uh oh!

njoubert-cleverage Dec 8, 2025

Uh oh!

njoubert-cleverage Dec 8, 2025

Uh oh!

njoubert-cleverage Dec 8, 2025

Uh oh!

njoubert-cleverage Dec 8, 2025

Uh oh!

njoubert-cleverage Dec 8, 2025

Uh oh!

njoubert-cleverage Dec 9, 2025

Uh oh!

njoubert-cleverage Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

xaviermarchegay commented Dec 8, 2025

Description

Requirements

Uh oh!

njoubert-cleverage Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

njoubert-cleverage commented Dec 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

njoubert-cleverage Dec 8, 2025 •

edited

Loading