Made estimate_size more resilient to missing or malformed CONTENT_LENGTH header #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was batch downloading a bunch of videos and some of the CDN servers did not think it important to send a CONTENT_LENGTH headers which made the process crash after fetching half of the video. 127 of 188 videos had that issue for some reason.
I didn't have time to properly refactor
estimate_sizeto return an error in case the header is missing and to makedownload_streamshandle the fallback case properly if there is no estimate available so consider this more of a hotfix.Thanks for making this cool tool btw. I am enjoying it.
Cheers!