Fix namespaced symbols in syntax quoted binding vector#79
Open
yuhan0 wants to merge 1 commit intoclj-commons:masterfrom
Open
Fix namespaced symbols in syntax quoted binding vector#79yuhan0 wants to merge 1 commit intoclj-commons:masterfrom
yuhan0 wants to merge 1 commit intoclj-commons:masterfrom
Conversation
Member
|
Could I ask you to add a test which demonstrates the breaking prior to this fix, and that passes after this fix? |
Author
|
I don't think there are any observed breakages due to the prior behaviour, because (deftype Foo []
Object
(toString [invalid/binding]
"no error"))This PR simply makes the output more robust, in case tooling or future versions decide to treat this as invalid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These underscores in a syntax quoted form cause the macroexpansion to contain the following technically invalid binding forms (even if
deftypeaccepts it without complaining)