Fixed inverted wasm-opt condition
#3930
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egormanga
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
Contributor
Author
|
@bfops — since I believe you're the one triaging, please notice this as it's probably an important performance fix. |
bfops
approved these changes
Jan 6, 2026
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
This seems correct to me! Thank you for catching this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Reverted the incorrect inversion of
build_debugcondition introduced by bb43213 that resulted in only debug builds being optimized instead of only release ones, as the comment just below says.API and ABI breaking changes
None.
Expected complexity level and risk
1.
Testing
.opt.wasmfiles disappear at some point)