-
Notifications
You must be signed in to change notification settings - Fork 135
Review Daniel Seto #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Comprueba el funcionamiento correcto del patrón Singleton
Test de adquisición de dos objetos reusables diferentes
Comprueba la excepción NotFreeInstanceException si se solicitan más de dos objetos reusable
Comprueba que se liberan correctamente los objetos del pool y quedan a disposición de los clientes.
Comprueba que no se permite liberar un objeto ya liberado.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
===============================================
+ Coverage 6.819% 78.948% +72.130%
- Complexity 3 20 +17
===============================================
Files 6 6
Lines 44 76 +32
Branches 1 1
===============================================
+ Hits 3 60 +57
+ Misses 41 16 -25 ☔ View full report in Codecov by Sentry. |
| import org.junit.Before; | ||
| import org.junit.Test; | ||
|
|
||
| import java.lang.reflect.Field; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿Es necesario este import?
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿Es necesario esta imagen?
clopezno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preparado para integrar.
|
|
||
| **¿Cuál es el número de fallos encontrados en el código?** | ||
|
|
||
| No se han encontrado fallos en el código cubierto por el conjunto de casos diseñado, como puede comprobarse en el log de Travis correspondiente al último build del proyecto: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
El éxito del diseño de pruebas es encontrar errores. A pesar de tener 100% de cobertura en los test pueden existir fallos.
Aplica la técnica de valores límite. En este ejercicio se puede probar que sucede cuando se libera instancias null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
No description provided.