Skip to content

Conversation

@clopezno
Copy link
Owner

No description provided.

dsr0018 and others added 12 commits February 19, 2020 11:15
Comprueba el funcionamiento correcto del patrón Singleton
Test de adquisición de dos objetos reusables diferentes
Comprueba la excepción NotFreeInstanceException si se solicitan más de
dos objetos reusable
Comprueba que se liberan correctamente los objetos del pool y quedan a
disposición de los clientes.
Comprueba que no se permite liberar un objeto ya liberado.
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.948%. Comparing base (704d822) to head (66c9d58).
Report is 46 commits behind head on master.

Files with missing lines Patch % Lines
...c/test/ubu/gii/dass/test/c01/ReusablePoolTest.java 94.286% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             master        #6        +/-   ##
===============================================
+ Coverage     6.819%   78.948%   +72.130%     
- Complexity        3        20        +17     
===============================================
  Files             6         6                
  Lines            44        76        +32     
  Branches          1         1                
===============================================
+ Hits              3        60        +57     
+ Misses           41        16        -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

import org.junit.Before;
import org.junit.Test;

import java.lang.reflect.Field;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Es necesario este import?

@@ -0,0 +1 @@

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Es necesario esta imagen?

Copy link
Owner Author

@clopezno clopezno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preparado para integrar.

@clopezno clopezno changed the title Review Review Daniel Seto Feb 24, 2020

**¿Cuál es el número de fallos encontrados en el código?**

No se han encontrado fallos en el código cubierto por el conjunto de casos diseñado, como puede comprobarse en el log de Travis correspondiente al último build del proyecto:
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El éxito del diseño de pruebas es encontrar errores. A pesar de tener 100% de cobertura en los test pueden existir fallos.
Aplica la técnica de valores límite. En este ejercicio se puede probar que sucede cuando se libera instancias null.

@clopezno clopezno requested a review from Copilot March 4, 2025 11:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants