Prevent TypeError when task json data missing#114
Open
alanhamlett wants to merge 2 commits intocloseio:masterfrom
alanhamlett:prevent-typeerror-invalid-task-json
Open
Prevent TypeError when task json data missing#114alanhamlett wants to merge 2 commits intocloseio:masterfrom alanhamlett:prevent-typeerror-invalid-task-json
alanhamlett wants to merge 2 commits intocloseio:masterfrom
alanhamlett:prevent-typeerror-invalid-task-json
Conversation
Member
I've seen this sometimes, but usually only if I manually messed with Redis to clear keys and didn't properly clean up, in which case the key doesn't exist. I thought of making this change as well, but I think I'd prefer us to fail explicitly here. Any further thoughts @jkemp101 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #112.
This prevents an exception when calling
Task.tasks_from_queue, but this doesn't fix the root problem of the task being created with invalid json data:tasktiger/tasktiger/task.py
Line 312 in 10b5fe7