Skip to content

Include original task id with batched parameters#169

Open
jkemp101 wants to merge 3 commits intomasterfrom
batch-current-task
Open

Include original task id with batched parameters#169
jkemp101 wants to merge 3 commits intomasterfrom
batch-current-task

Conversation

@jkemp101
Copy link
Member

This allows clients to know which task ID a set of parameters came from. Useful for logging purposes.

@jkemp101 jkemp101 requested a review from thomasst December 14, 2020 20:42
@thomasst
Copy link
Member

Would tiger.current_tasks[N].id be sufficient to do this? For a single task you'd also use tiger.current_task.id to get the ID.

@thomasst
Copy link
Member

What do we want to decide here?

@jkemp101 jkemp101 removed the request for review from thomasst December 22, 2020 19:28
@jkemp101
Copy link
Member Author

I started an alternative implementation using your suggestion. I removed you as a reviewer on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants