Conversation
thomasst
force-pushed
the
reduce-idle-activity
branch
from
5d9afc3 to
1e376f4
Compare
jkemp101
reviewed
Feb 17, 2021
Member
jkemp101
left a comment
jkemp101
left a comment
There was a problem hiding this comment.
Code looks fine. Would probably want to do a test with a bunch of scheduled queues to see what performance improvement it makes to make sure we understand how this helps.
| # one Redis query to enter this block since every single worker calls | ||
| # this every second. | ||
| # XXX: Ideally, we should keep track of workers and take turns. | ||
| key = self._key("lock", "secondary_tasks") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces Redis ops with N idle workers from from
6 + 4 * (N-1)to7 + 1 * (N-1)per second.For example, if 100 workers are idle, Redis queries would be reduced from 402 down to 106 per second.