Merged
Conversation
Member
Author
|
@thomasst any PRs you'd like to merge before we release 0.12? I see you have 3 PRs recently opened. |
Member
There is another fix I wanted to do today or tomorrow. I'll see if I can squeeze it in today. |
Member
Author
|
No worries, I can wait. |
Member
|
FYI, this one is still pending a second review: #188 |
thomasst
reviewed
Mar 25, 2021
Member
thomasst
left a comment
thomasst
left a comment
There was a problem hiding this comment.
Should be ready to release now. Can you amend the changelog?
thomasst
approved these changes
Mar 25, 2021
Member
thomasst
left a comment
thomasst
left a comment
There was a problem hiding this comment.
Looks good. In the future I would probably just refer to the shortened commit hash in each change log entry to avoid linking to GitHub-specific stuff. No big deal though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going to release 0.12 before merging #185 and #186.