Skip to content

Fixed 'Add-WindowsUser' when creating a user with a long password #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ionutbalutoiu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed 'Add-WindowsUser' when creating a user with a long password #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion JujuWindowsUtils/JujuWindowsUtils.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ function Add-WindowsUser {
}
$cmd = @("net.exe", "user", $Username)
if (!$exists) {
$cmd += @($Password, "/add", "/expires:never", "/active:yes")
$cmd += @($Password, "/add", "/expires:never", "/active:yes", "/Y")
if($Fullname) {
$cmd += "/fullname:{0}" -f @($Fullname)
}
Expand Down
8 changes: 4 additions & 4 deletions JujuWindowsUtils/Tests/JujuWindowsUtils.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ Describe "Test Add-WindowsUser" {
(Compare-Object $Command @("net.exe", "user", $fakeUser, $fakePassword,
"/add", ("/fullname:{0}" -f @($fakeFullname)),
("/comment:{0}" -f @($fakeDescription)),
"/expires:never", "/active:yes")) -eq $null
"/expires:never", "/active:yes", "/Y")) -eq $null
}
}
}
Expand All @@ -234,7 +234,7 @@ Describe "Test Add-WindowsUser" {
Assert-MockCalled Invoke-JujuCommand -ModuleName JujuWindowsUtils -Exactly 1 -ParameterFilter {
(Compare-Object $Command @("net.exe", "user", $fakeUser, $fakePassword,
"/add", ("/comment:{0}" -f @($fakeDescription)),
"/expires:never", "/active:yes")) -eq $null
"/expires:never", "/active:yes", "/Y")) -eq $null
}
}
}
Expand All @@ -248,7 +248,7 @@ Describe "Test Add-WindowsUser" {
Assert-MockCalled Invoke-JujuCommand -ModuleName JujuWindowsUtils -Exactly 1 -ParameterFilter {
(Compare-Object $Command @("net.exe", "user", $fakeUser, $fakePassword,
"/add", ("/fullname:{0}" -f @($fakeFullname)),
"/expires:never", "/active:yes")) -eq $null
"/expires:never", "/active:yes", "/Y")) -eq $null
}
}
}
Expand All @@ -261,7 +261,7 @@ Describe "Test Add-WindowsUser" {
Assert-MockCalled Get-AccountObjectByName -ModuleName JujuWindowsUtils -Exactly 1
Assert-MockCalled Invoke-JujuCommand -ModuleName JujuWindowsUtils -Exactly 1 -ParameterFilter {
(Compare-Object $Command @("net.exe", "user", $fakeUser, $fakePassword,
"/add", "/expires:never", "/active:yes")) -eq $null
"/add", "/expires:never", "/active:yes", "/Y")) -eq $null
}
}
}
Expand Down