Open
Conversation
Contributor
|
Will try to look at this soon, but it may be next week. |
Author
|
It's no rush, we're just trying to optimize our eventing and this is something I wanted to check |
Contributor
|
There are a few things I'd probably want to change here - I wonder if the best thing is for me to create an PR from scratch rather than leave a bunch of nitpicks, then get you to review that new PR. Does that work for you? |
Author
|
Absolutely, it was just a PoC |
Contributor
|
Great. I'll try to come up with something next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change optimizes the binary mode formatter when UTF8 is chosen, and allows the memory stream implementation to be overridden (e.g. RecyclableMemoryStream)