Skip to content

Conversation

@HueCodes
Copy link

parseCronExpression throws for malformed cron strings. In the alarm
handler this prevents remaining schedules from executing and leaves
the invalid schedule in the database, blocking future alarms.

Wrap in try/catch and remove invalid schedules to unblock the loop.

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2026

⚠️ No Changeset found

Latest commit: 1002fe8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@threepointone
Copy link
Contributor

we should probably validate them when adding

@HueCodes
Copy link
Author

Yeah, getNextCronTime at line 1108 already throws for invalid expressions on creation. This just handles the edge case of corrupted data. Happy to add explicit validation there too if you'd prefer. Just let me know and thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants