Add more test, remove dead code

[prymitive]

No description provided.

[github-actions]

This pull request was validated by pint.

✔️ No problems found

Stats

Stat	Value
Version	v0.78.0-24-g2d7871b1
Number of rules parsed	9
Number of rules checked	9
Number of problems found	0
Number of offline checks	0
Number of online checks	0
Checks duration	0

Problems

No problems reported

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.31%. Comparing base (b957b57) to head (2d7871b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1653      +/-   ##
==========================================
+ Coverage   98.76%   99.31%   +0.54%     
==========================================
  Files         109      109              
  Lines       13251    13213      -38     
==========================================
+ Hits        13087    13122      +35     
+ Misses        101       54      -47     
+ Partials       63       37      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
GlobFinder-4          18.62m ± ∞ ¹   18.68m ± ∞ ¹       ~ (p=0.310 n=5)
GitFinder-4           374.2m ± ∞ ¹   377.7m ± ∞ ¹       ~ (p=0.151 n=5)
CheckRules-4           9.484 ± ∞ ¹    9.462 ± ∞ ¹       ~ (p=0.841 n=5)
RuleIsIdentical-4     5.633m ± ∞ ¹   5.709m ± ∞ ¹  +1.34% (p=0.016 n=5)
GetChecksForEntry-4   108.0m ± ∞ ¹   108.9m ± ∞ ¹       ~ (p=0.548 n=5)
geomean               132.1m         132.9m        +0.66%
¹ need >= 6 samples for confidence interval at level 0.95

                    │    old.txt    │                new.txt                │
                    │     B/op      │     B/op       vs base                │
GlobFinder-4          7.137Mi ± ∞ ¹   7.137Mi ± ∞ ¹       ~ (p=0.151 n=5)
GitFinder-4           15.96Mi ± ∞ ¹   15.96Mi ± ∞ ¹       ~ (p=0.841 n=5)
CheckRules-4          982.6Mi ± ∞ ¹   982.6Mi ± ∞ ¹       ~ (p=0.841 n=5)
RuleIsIdentical-4       0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
GetChecksForEntry-4   56.55Mi ± ∞ ¹   56.55Mi ± ∞ ¹       ~ (p=0.056 n=5)
geomean                           ³                  +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │   old.txt    │               new.txt                │
                    │  allocs/op   │  allocs/op    vs base                │
GlobFinder-4          111.6k ± ∞ ¹   111.6k ± ∞ ¹       ~ (p=0.921 n=5)
GitFinder-4           151.1k ± ∞ ¹   151.1k ± ∞ ¹       ~ (p=0.794 n=5)
CheckRules-4          14.68M ± ∞ ¹   14.69M ± ∞ ¹       ~ (p=0.690 n=5)
RuleIsIdentical-4      0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
GetChecksForEntry-4   915.8k ± ∞ ¹   915.8k ± ∞ ¹  +0.00% (p=0.024 n=5)
geomean                          ³                 +0.01%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/parser
        │   old.txt    │              new.txt               │
        │    sec/op    │    sec/op     vs base              │
Parse-4   16.46m ± ∞ ¹   16.29m ± ∞ ¹  -1.00% (p=0.008 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

        │    old.txt    │            new.txt             │
        │     B/op      │     B/op       vs base         │
Parse-4   6.309Mi ± ∞ ¹   6.309Mi ± ∞ ¹  ~ (p=1.000 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

        │   old.txt    │            new.txt            │
        │  allocs/op   │  allocs/op    vs base         │
Parse-4   103.2k ± ∞ ¹   103.2k ± ∞ ¹  ~ (p=1.000 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/cloudflare/pint/internal/parser/source
               │   old.txt    │            new.txt            │
               │    sec/op    │    sec/op     vs base         │
LabelsSource-4   5.439m ± ∞ ¹   5.442m ± ∞ ¹  ~ (p=0.841 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

               │    old.txt    │            new.txt             │
               │     B/op      │     B/op       vs base         │
LabelsSource-4   4.377Mi ± ∞ ¹   4.386Mi ± ∞ ¹  ~ (p=0.095 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

               │   old.txt    │              new.txt               │
               │  allocs/op   │  allocs/op    vs base              │
LabelsSource-4   35.86k ± ∞ ¹   35.93k ± ∞ ¹  +0.20% (p=0.008 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/cloudflare/pint/internal/promapi
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
QueryCacheOnlySet-4   102.1n ± ∞ ¹   102.7n ± ∞ ¹       ~ (p=0.952 n=5)
QueryCacheSetGrow-4   389.8n ± ∞ ¹   425.9n ± ∞ ¹       ~ (p=0.151 n=5)
QueryCacheGetMiss-4   16.30n ± ∞ ¹   16.36n ± ∞ ¹       ~ (p=0.143 n=5)
QueryCacheGC/0%-4     33.44µ ± ∞ ¹   33.39µ ± ∞ ¹       ~ (p=1.000 n=5)
QueryCacheGC/1%-4     34.46µ ± ∞ ¹   34.30µ ± ∞ ¹       ~ (p=1.000 n=5)
QueryCacheGC/10%-4    38.89µ ± ∞ ¹   38.43µ ± ∞ ¹       ~ (p=0.421 n=5)
QueryCacheGC/20%-4    67.39µ ± ∞ ¹   67.80µ ± ∞ ¹       ~ (p=0.690 n=5)
QueryCacheGC/25%-4    66.97µ ± ∞ ¹   66.69µ ± ∞ ¹       ~ (p=0.056 n=5)
QueryCacheGC/50%-4    65.34µ ± ∞ ¹   65.34µ ± ∞ ¹       ~ (p=1.000 n=5)
QueryCacheGC/75%-4    49.71µ ± ∞ ¹   49.94µ ± ∞ ¹       ~ (p=0.310 n=5)
QueryCacheGC/99%-4    49.61µ ± ∞ ¹   49.98µ ± ∞ ¹       ~ (p=0.841 n=5)
QueryCacheGC/100%-4   49.75µ ± ∞ ¹   49.81µ ± ∞ ¹       ~ (p=1.000 n=5)
geomean               10.04µ         10.12µ        +0.80%
¹ need >= 6 samples for confidence interval at level 0.95

                    │    old.txt    │                new.txt                │
                    │     B/op      │     B/op       vs base                │
QueryCacheOnlySet-4     64.00 ± ∞ ¹     64.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheSetGrow-4     136.0 ± ∞ ¹     135.0 ± ∞ ¹       ~ (p=0.794 n=5)
QueryCacheGetMiss-4     0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/0%-4       0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/1%-4       0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/10%-4      0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/20%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/25%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/50%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/75%-4      48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/99%-4      48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/100%-4     48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
geomean                           ³                  -0.06%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │   old.txt   │               new.txt               │
                    │  allocs/op  │  allocs/op   vs base                │
QueryCacheOnlySet-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheSetGrow-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGetMiss-4   0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/0%-4     0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/1%-4     0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/10%-4    0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/20%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/25%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/50%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/75%-4    1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/99%-4    1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/100%-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
geomean                         ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean