Skip to content

Conversation

@prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.78.0-38-ge8bbd17b
Number of rules parsed 9
Number of rules checked 9
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.56%. Comparing base (e504ce0) to head (e8bbd17).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1659   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files         109      109           
  Lines       13203    13203           
=======================================
  Hits        13146    13146           
  Misses         32       32           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
GlobFinder-4          18.12m ± ∞ ¹   17.69m ± ∞ ¹       ~ (p=0.310 n=5)
GitFinder-4           289.6m ± ∞ ¹   286.1m ± ∞ ¹       ~ (p=0.548 n=5)
CheckRules-4           9.542 ± ∞ ¹    9.503 ± ∞ ¹       ~ (p=1.000 n=5)
RuleIsIdentical-4     5.225m ± ∞ ¹   5.336m ± ∞ ¹  +2.13% (p=0.008 n=5)
GetChecksForEntry-4   105.2m ± ∞ ¹   104.5m ± ∞ ¹       ~ (p=0.548 n=5)
geomean               122.4m         121.8m        -0.50%
¹ need >= 6 samples for confidence interval at level 0.95

                    │    old.txt    │                new.txt                 │
                    │     B/op      │      B/op       vs base                │
GlobFinder-4          7.136Mi ± ∞ ¹    7.136Mi ± ∞ ¹       ~ (p=0.690 n=5)
GitFinder-4           15.95Mi ± ∞ ¹    15.96Mi ± ∞ ¹       ~ (p=0.690 n=5)
CheckRules-4          993.2Mi ± ∞ ¹   1012.3Mi ± ∞ ¹  +1.92% (p=0.008 n=5)
RuleIsIdentical-4       0.000 ± ∞ ¹      0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
GetChecksForEntry-4   56.55Mi ± ∞ ¹    56.55Mi ± ∞ ¹       ~ (p=0.841 n=5)
geomean                           ³                   +0.38%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │   old.txt    │               new.txt                │
                    │  allocs/op   │  allocs/op    vs base                │
GlobFinder-4          111.6k ± ∞ ¹   111.6k ± ∞ ¹       ~ (p=0.524 n=5)
GitFinder-4           151.1k ± ∞ ¹   151.1k ± ∞ ¹       ~ (p=0.135 n=5)
CheckRules-4          14.75M ± ∞ ¹   14.75M ± ∞ ¹       ~ (p=0.095 n=5)
RuleIsIdentical-4      0.000 ± ∞ ¹    0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
GetChecksForEntry-4   915.8k ± ∞ ¹   915.8k ± ∞ ¹       ~ (p=1.000 n=5)
geomean                          ³                 +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/parser
        │   old.txt    │            new.txt            │
        │    sec/op    │    sec/op     vs base         │
Parse-4   16.46m ± ∞ ¹   16.31m ± ∞ ¹  ~ (p=0.690 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

        │    old.txt    │            new.txt             │
        │     B/op      │     B/op       vs base         │
Parse-4   6.309Mi ± ∞ ¹   6.309Mi ± ∞ ¹  ~ (p=0.690 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

        │   old.txt    │            new.txt            │
        │  allocs/op   │  allocs/op    vs base         │
Parse-4   103.2k ± ∞ ¹   103.2k ± ∞ ¹  ~ (p=1.000 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/cloudflare/pint/internal/parser/source
               │   old.txt    │              new.txt               │
               │    sec/op    │    sec/op     vs base              │
LabelsSource-4   5.254m ± ∞ ¹   5.411m ± ∞ ¹  +3.01% (p=0.032 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

               │    old.txt    │            new.txt             │
               │     B/op      │     B/op       vs base         │
LabelsSource-4   4.393Mi ± ∞ ¹   4.394Mi ± ∞ ¹  ~ (p=0.690 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

               │   old.txt    │            new.txt            │
               │  allocs/op   │  allocs/op    vs base         │
LabelsSource-4   35.93k ± ∞ ¹   35.93k ± ∞ ¹  ~ (p=1.000 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/cloudflare/pint/internal/promapi
                    │   old.txt    │               new.txt               │
                    │    sec/op    │    sec/op      vs base              │
QueryCacheOnlySet-4   98.42n ± ∞ ¹   101.40n ± ∞ ¹       ~ (p=0.452 n=5)
QueryCacheSetGrow-4   426.3n ± ∞ ¹    436.4n ± ∞ ¹       ~ (p=0.095 n=5)
QueryCacheGetMiss-4   24.03n ± ∞ ¹    24.10n ± ∞ ¹       ~ (p=0.548 n=5)
QueryCacheGC/0%-4     32.10µ ± ∞ ¹    32.72µ ± ∞ ¹  +1.94% (p=0.032 n=5)
QueryCacheGC/1%-4     33.16µ ± ∞ ¹    33.09µ ± ∞ ¹       ~ (p=1.000 n=5)
QueryCacheGC/10%-4    35.74µ ± ∞ ¹    36.31µ ± ∞ ¹       ~ (p=0.310 n=5)
QueryCacheGC/20%-4    58.92µ ± ∞ ¹    58.82µ ± ∞ ¹       ~ (p=0.841 n=5)
QueryCacheGC/25%-4    59.24µ ± ∞ ¹    58.71µ ± ∞ ¹       ~ (p=0.690 n=5)
QueryCacheGC/50%-4    59.63µ ± ∞ ¹    59.62µ ± ∞ ¹       ~ (p=0.841 n=5)
QueryCacheGC/75%-4    46.18µ ± ∞ ¹    46.29µ ± ∞ ¹       ~ (p=1.000 n=5)
QueryCacheGC/99%-4    46.54µ ± ∞ ¹    46.14µ ± ∞ ¹       ~ (p=0.690 n=5)
QueryCacheGC/100%-4   45.73µ ± ∞ ¹    47.24µ ± ∞ ¹       ~ (p=0.056 n=5)
geomean               9.800µ          9.885µ        +0.87%
¹ need >= 6 samples for confidence interval at level 0.95

                    │    old.txt    │                new.txt                │
                    │     B/op      │     B/op       vs base                │
QueryCacheOnlySet-4     64.00 ± ∞ ¹     64.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheSetGrow-4     114.0 ± ∞ ¹     114.0 ± ∞ ¹       ~ (p=0.881 n=5)
QueryCacheGetMiss-4     0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/0%-4       0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/1%-4       0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/10%-4      0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/20%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/25%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/50%-4    18.09Ki ± ∞ ¹   18.09Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/75%-4      48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/99%-4      48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/100%-4     48.00 ± ∞ ¹     48.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
geomean                           ³                  +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │   old.txt   │               new.txt               │
                    │  allocs/op  │  allocs/op   vs base                │
QueryCacheOnlySet-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheSetGrow-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGetMiss-4   0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/0%-4     0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/1%-4     0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/10%-4    0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/20%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/25%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/50%-4    4.000 ± ∞ ¹   4.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/75%-4    1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/99%-4    1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC/100%-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
geomean                         ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

@prymitive prymitive merged commit 068574e into main Dec 9, 2025
20 checks passed
@prymitive prymitive deleted the prom branch December 9, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants