Upgrade bincode to released version 2 and fix compilation when disabled

Cargo.toml

@@ -25,7 +25,7 @@ license = "Apache-2.0"
 
 [workspace.dependencies]
 akd = { version = "0.11", default-features = false }
-bincode = "2.0.0-rc.3"
+bincode = "2"
 anyhow = "1.0"
 clap = { version = "4.5", features = ["derive"] }
 clap-verbosity-flag = "2.2.0"

plexi_core/src/lib.rs

@@ -105,8 +105,8 @@ impl Encode for Ciphersuite {
 }
 
 #[cfg(feature = "bincode")]
-impl Decode for Ciphersuite {
-    fn decode<D: bincode::de::Decoder>(
+impl<Context> Decode<Context> for Ciphersuite {
+    fn decode<D: bincode::de::Decoder<Context = Context>>(
         decoder: &mut D,
     ) -> Result<Self, bincode::error::DecodeError> {
         let value: u32 = bincode::Decode::decode(decoder)?;
@@ -115,8 +115,8 @@ impl Decode for Ciphersuite {
 }
 
 #[cfg(feature = "bincode")]
-impl<'de> BorrowDecode<'de> for Ciphersuite {
-    fn borrow_decode<B: bincode::de::BorrowDecoder<'de>>(
+impl<'de, Context> BorrowDecode<'de, Context> for Ciphersuite {
+    fn borrow_decode<B: bincode::de::BorrowDecoder<'de, Context = Context>>(
         buffer: &mut B,
     ) -> Result<Self, bincode::error::DecodeError> {
         let value = u32::borrow_decode(buffer)?;
@@ -485,8 +485,11 @@ impl SignatureResponse {
     pub fn verify(&self, verifying_key: &[u8]) -> anyhow::Result<()> {
         // at the time of writing, all versions use ed25519 keys. This simplifies parsing of the verifying key.
         match self.version {
-            #[cfg(feature = "bincode")]
-            Ciphersuite::BincodeEd25519 => (),
+            Ciphersuite::BincodeEd25519 => {
+                if !cfg!(feature = "bincode") {
+                    return Err(anyhow!("Verification is not supported for bincode."));
+                }
+            }
             Ciphersuite::ProtobufEd25519 => (),
             Ciphersuite::Unknown(_) => {
                 return Err(anyhow!(