Open
Conversation
cristaloleg
reviewed
May 6, 2023
go.mod
Outdated
| require golang.org/x/sys v0.0.0-20210119212857-b64e53b001e4 | ||
| require ( | ||
| golang.org/x/sys v0.0.0-20210119212857-b64e53b001e4 | ||
| google.golang.org/grpc v1.49.0 |
There was a problem hiding this comment.
That's a heavy dependency just for 1 example, better to keep in a separate module.
Author
There was a problem hiding this comment.
That's a heavy dependency just for 1 example, better to keep in a separate module.
Thank you for your feedback and suggestions. To address this, I will create a separate module for the example code to keep the dependencies isolated.
Additionally, I think that http_example_test.go and tcp_example_test.go could also be included in this module. I'm not sure if this would be appropriate though.
Have a nice day!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am working on the issue: Add an example for grpc servers
It 's my first time to make a PR in Github.I hope to know if there is something I did wrong in this PR.
Thanks for your time.May you have a nice day!