Handle Buffers being passed back (even though journey is intended to be JSON only)#19
Open
dhendo wants to merge 1 commit intocloudhead:masterfrom
Open
Handle Buffers being passed back (even though journey is intended to be JSON only)#19dhendo wants to merge 1 commit intocloudhead:masterfrom
dhendo wants to merge 1 commit intocloudhead:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a buffer is returned from a route, currently Journey will error on the line, as byteLength is expecting a string.
Buffer.byteLength(outcome.body);Seeing as converting a Buffer to JSON is not a huge amount of use, my patch returns the buffer, and retains the Content-Type as is.
I know journey is supposed to be JSON-only, but the code change to support binary files is minimal and low impact.