-
Notifications
You must be signed in to change notification settings - Fork 29
Implements #265(Add social links to website) along with a few minor changes #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Awesome work with the icons! I'm wondering about the /community since it now gives a 404 / page doesn't exist. Do we want to link to the End Users page instead? |
|
As we discussed on the call, we can work on building out a proper /community page—making End Users one section, along with other relevant info. |
jsilvela
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very nice. I have some inline comments, and few observations:
- the top of the page now loses the media links it had, only keeping GH?
- I think in the Learn section it would be good to add Tutorials
- the "How to contribute" link makes more sense in the Community section IMO
2-3. yes, I’ll take care of that. We can also discuss the footer structure - which links to include and how to organize them. Effect of change |
chore: added bluesky, mastodon svg's chore: improved nav layout feat: redesign footer layout and add community links - Improved nav layout - Added bluesky, mastodon SVGs - Improved package.json formatting Signed-off-by: Priyanshu Singh <reveur.guy99@gmail.com>
Co-authored-by: Jaime Silvela <jaime.silvela@mailfence.com> Signed-off-by: Priyanshu Singh <reveur.guy99@gmail.com>
Signed-off-by: Priyanshu Singh <reveur.guy99@gmail.com>
Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
) The links to social networks BlueSky and Mastodon were added, and a little improvement was made to the footer of the webpage Signed-off-by: Priyanshu Singh <reveur.guy99@gmail.com> Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com> Co-authored-by: Jaime Silvela <jaime.silvela@mailfence.com> Co-authored-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
) The links to social networks BlueSky and Mastodon were added, and a little improvement was made to the footer of the webpage Signed-off-by: Priyanshu Singh <reveur.guy99@gmail.com> Signed-off-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com> Co-authored-by: Jaime Silvela <jaime.silvela@mailfence.com> Co-authored-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com> 65ef7d1




This PR introduces several improvements:
These changes are with respect to #265