Use exec in entrypoint.sh to forward signals correctly #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoard
requested review from
NiccoloFei,
fcanovai,
gbartolini,
jbattiato,
litaocdl,
mnencia and
sxd
as code owners
Signed-off-by: Ali Afsharzadeh <afsharzadeh8@gmail.com>
guoard
force-pushed
the
fix_forward_signals
branch
from
89156d8 to
414ac87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
execinentrypoint.shso the process runs as PID 1 and move the pgbouncer command toCMDto allow customizing the command.Before this change, container did not stop gracefully and pgbouncer did not receive
SIGTERM.