Support full-text search DDLs#111
Merged
makenowjust merged 40 commits intocloudspannerecosystem:mainfrom Oct 25, 2024
Merged
Conversation
13b3825 to
d3d9be2
Compare
makenowjust
requested changes
Oct 17, 2024
Collaborator
makenowjust
left a comment
There was a problem hiding this comment.
I have some minor suggestions and give a major issue. Please check it.
makenowjust
requested changes
Oct 17, 2024
Contributor
Author
|
This PR still depends on #142, so I turn this PR as draft. |
Contributor
Author
|
Merge OPTIONS and conflict is resolved. Re-opened. |
Contributor
Author
|
Merged to fix conflicts. |
makenowjust
requested changes
Oct 24, 2024
Co-authored-by: Hiroya Fujinami <make.just.on@gmail.com>
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes
CREATE SEARCH INDEX,ALTER SEARCH INDEX, andDROP SEARCH INDEXstatements.Depends on helper functions in #101, so this branch includes implementation ofCREATE PROPERTY GRAPH, andDROP PROPERTY GRAPH.It needs rebase after merge that.
rebased.
CREATE SEARCH INDEXALTER SEARCH INDEXDROP SEARCH INDEXEnsure
CREATE TABLEin full-text search examples can be parsed.STOREDoptional in generated columnsHIDDENcolumnImplementast.SearchIndexOptionsonast.GenericOptionsGeneralize OPTIONS behavior #137Add
Pos.Add()andfirstValidto refactorEnd()2127e0efix #108
depends on #120