Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates documentation and code to avoid the deprecated DATE_RFC7231 constant in PHP 8.5+. The change replaces usage of the deprecated constant with manual date formatting using gmdate() to maintain HTTP-compliant date formatting.
- Replace
DATE_RFC7231constant with manual date formatting in documentation - Update
FilesystemHandler.phpto usegmdate()with 'T' timezone identifier - Expand documentation with clearer guidance on HTTP date formatting requirements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/FilesystemHandler.php | Updates Last-Modified header generation to use gmdate() with timezone identifier instead of manual GMT append |
| docs/api/response.md | Replaces deprecated DATE_RFC7231 usage in examples and expands documentation with alternative formatting approaches |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the documentation to avoid the deprecated
DATE_RFC7231constant (PHP 8.5+)Builds on top of #52 and php/php-src#12989
Refs https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_date_rfc7231_and_datetimeinterfacerfc7231 and https://www.php.net/manual/en/timezones.others.php