Skip to content

Conversation

@JustinMeimar
Copy link
Collaborator

@JustinMeimar JustinMeimar commented Sep 17, 2024

Addresses #47

Not to be merged -- WIP

@kuzi117
Copy link
Contributor

kuzi117 commented Sep 17, 2024

I realize I just dumped a big text block on #47. I think this is a good idea so far. Addresses discoverability at least insofar as separating from other users, but you're still probably going to have hundreds of files. Clean up can just be rm -r by the user (or the tester). Likely puts the weight of the files on the user's network storage (and I've seen some student that have somehow filled their quota and don't want to delete things) which is on them to maintain. Nice work.

}
}
// Create the temporary input and ouput files
std::ofstream createInsFile(insPath);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any reason to create the files here. Opening and immediately closing the files is just extra file system interaction. The calls to open have O_CREAT on them, so they should make new files. Making the directory is important though.

Copy link
Collaborator Author

@JustinMeimar JustinMeimar Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks good point, I will create the files when they need to be used in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants