-
Notifications
You must be signed in to change notification settings - Fork 8
Removed anaCache step #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f88a7dc
work in progress
kandrosov 5dd51a8
Merge remote-tracking branch 'origin/main' into removeAnaCache
kandrosov cfdf39c
Split xs, pu, lumi and mc weights
kandrosov b9a98af
weight_MC -> wegiht_base
kandrosov 0da7f12
Merge remote-tracking branch 'origin/main' into removeAnaCache
kandrosov 2dabbb0
formatting
kandrosov 05d50ae
Merge remote-tracking branch 'origin/main' into removeAnaCache
kandrosov a200199
Added pu up/down variations to the base weight
kandrosov 0f18f6e
formatting
kandrosov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
enabled=False, the branch is not defined (line 60-65) but it is still added toshape_weights_dict(line 68-71). This meansshape_weights_dictwill contain references to undefined branches, which will cause runtime errors when these branches are later accessed in the weight formula calculation in Corrections.py (line 464). Either the branch should always be added toshape_weights_dictregardless of theenabledflag, or the addition toshape_weights_dictshould also be conditional onenabled=True.