fixed bug in 2024 dataset + grouping data for sample and era letter #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandrosov
requested changes
Jan 30, 2026
Contributor
kandrosov
left a comment
kandrosov
left a comment
There was a problem hiding this comment.
Do not change the AnaTupleFileListBuilderTask branches definition. Only modify the logic inside AnaTupleFileList.py.
…r_anaTupleFileList
…r_anaTupleFileList
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#13941443 started |
kandrosov
added
enhancement
Collaborator
|
pipeline#13941443 failed |
Contributor
Author
|
@cms-flaf-bot please test
|
kandrosov
added
enhancement
Contributor
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#13948509 started |
Collaborator
|
pipeline#13948509 failed |
kandrosov
requested changes
Feb 3, 2026
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#13949523 started |
Collaborator
|
pipeline#13949523 passed |
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#13951659 started |
Collaborator
|
pipeline#13951659 failed |
kandrosov
requested changes
Feb 4, 2026
config/Processors/stitching_DY_amcatnlo_Vpt_NpNLO_singleFlavor.yaml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@cms-flaf-bot please test
|
Collaborator
|
pipeline#13958487 started |
Collaborator
|
pipeline#13958487 passed |
kandrosov
approved these changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses data organization and dataset configuration issues by separating data files by era letter instead of grouping them together. The changes enable proper grouping of datasets like "Muon_2022C" and "Muon_2022D" separately.
Changes:
- Fixed invalid dataset names in Run3_2024 config (removed leading slashes)
- Updated cross-section definitions to support both all-flavors and single-flavor variants
- Modified
fileNamePatternhandling from string to dictionary keyed by nanoAOD version - Added missing type mapping for
int8_tin FuseAnaTuples
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/checkDatasetConfigConsistency.py | Updated logic to handle fileNamePattern as dictionary with version keys |
| run_tools/law_customizations.py | Extracted get_nano_version method for reusability |
| config/dataset_exceptions.yaml | Added exception for DYto2L samples in Run3_2024 |
| config/crossSections13p6TeV.yaml | Added _allFlavors/_singleFlavor cross-section variants |
| config/Run3_2024/datasets.yaml | Fixed dataset names, updated cross-sections, added new samples |
| config/Run3_2023/datasets.yaml | Converted fileNamePattern to dict, added allFlavors entries |
| config/Run3_2022EE/datasets.yaml | Similar updates for fileNamePattern and cross-sections |
| config/Run3_2022/datasets.yaml | Similar updates for fileNamePattern and cross-sections |
| config/Processors/stitching_DY_amcatnlo_Vpt_NpNLO_allFlavors.yaml | New stitching config for all-flavors |
| config/Processors/stitching_DY_amcatnlo_Vpt_NpNLO.yaml | Updated to use singleFlavor cross-sections |
| AnaProd/tasks.py | Updated to retrieve fileNamePattern from dict by version |
| AnaProd/FuseAnaTuples.py | Added int8_t type mapping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to handle the data merge and file list definition.
Now the data are not grouped in one big data file but they are separated by era letter.
e.g.:
and they will be grouped in "Muon_2022C" and "Muon_2022D"