Skip to content

Add Tau-model to nbd#10

Open
Thammachath wants to merge 7 commits intocms-flashsim:mainfrom
Thammachath:main
Open

Add Tau-model to nbd#10
Thammachath wants to merge 7 commits intocms-flashsim:mainfrom
Thammachath:main

Conversation

@Thammachath
Copy link

No description provided.

@srimanob
Copy link

Hi @Thammachath

Just wondering, when you fill NanoAOD content for some quantities that you convert the value, do you convert back to original format, for example, idDeepTau2017v2p1VSjet ?

@francesco-vaselli
Copy link
Contributor

Hello @Thammachath ! Thank you for the pull request

We are going to review it as soon as possible. in the meantime though I think that the easiest thing would be running the package on your own branch and see if you can actually save a Flash NanoAOD with you model simulating taus. Let us know if that works so we can help you with debugging or proceed with the merge!

Best
Francesco

@Thammachath
Copy link
Author

Hi @Thammachath

Just wondering, when you fill NanoAOD content for some quantities that you convert the value, do you convert back to original format, for example, idDeepTau2017v2p1VSjet ?

@srimanob thank you for the warning. I forget to apply -1 to the bitmask to change idDeepTau2017v2p1VSjet and similar variable to original format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants