Add most common math functions from standard library#2
Add most common math functions from standard library#2fwyzard merged 1 commit intocms-patatrack:masterfrom
Conversation
.gitignore
Outdated
| *.app | ||
|
|
||
| # build folders | ||
| *build* |
There was a problem hiding this comment.
could this be /build* instead ?
|
@sbaldu I finally merged @AuroraPerego's #1 :-) |
|
Also, could you add tests for the new functions (but that's OK in a separate PR) ? |
Sure |
Of course, I'll do it in another PR :) |
.gitignore
Outdated
| /test/external/ | ||
|
|
||
| # build folders | ||
| */build/* |
There was a problem hiding this comment.
I'm confused, do you expect to have .../build folders in subdirectories ?
There was a problem hiding this comment.
I didn't see Aurora's PR so I was expecting to use CMake for building tests as well
There was a problem hiding this comment.
My bad, I left it pending for an year 🤷🏻
|
On second thought, can you remove the changes to If the |
Of course. |
|
Hope this is produced with a code generator: Could you please add the script as well? |
| } | ||
|
|
||
| XTD_DEVICE_FUNCTION | ||
| inline constexpr float acosf(float arg) { |
There was a problem hiding this comment.
sorry This is utterly wrong! Did you check "assembly"?
please call ::acosf at least for cuda and hip.
said that I wish to remind that both cuda and hip support templated std::acos and produce correct code.
v.
|
-1. Please make sure
|
I did it by hand using vim macros, which made the process relatively quick |
Thanks, I will look into all of these :) |
No description provided.