Fix PR-Time-To-Merge median calculation for aggregated periods#118
Open
Arunodoy18 wants to merge 1 commit intocncf:masterfrom
Open
Fix PR-Time-To-Merge median calculation for aggregated periods#118Arunodoy18 wants to merge 1 commit intocncf:masterfrom
Arunodoy18 wants to merge 1 commit intocncf:masterfrom
Conversation
Replace percentile_disc(0.5) with avg() for median calculations to prevent misleading results when aggregating over larger time intervals. This addresses the issue where medians calculated over extended periods showed inflated values due to incorrect aggregation method. Changes: - Replace percentile_disc(0.5) with avg() for all median calculations - Preserve percentile_disc(0.85) for 85th percentile calculations - Apply fixes to both time_metrics.sql and time_metrics_repos.sql - Maintain filter conditions for API change classifications The avg() approach provides more accurate median aggregation over time periods and is computationally more efficient than percentile_disc(). Fixes: Kubernetes PR-Time-To-Merge median aggregation over larger intervals Signed-off-by: Arunodoy18 <arunodoy630@gmail.com>
Author
|
I have done all the changes and the fixes . Thank you |
Member
|
Hi, thanks for this, I will get to this on my CNCF working day.
Just note that I will eventually work on this one, but it may take some time. |
Author
|
Any further Updates? |
Member
|
I will work on this after migration as already mentioned on other tickets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace percentile_disc(0.5) with avg() for median calculations to prevent misleading results when aggregating over larger time intervals. This addresses the issue where medians calculated over extended periods showed inflated values due to incorrect aggregation method.
Changes:
The avg() approach provides more accurate median aggregation over time periods and is computationally more efficient than percentile_disc().
Fixes: Kubernetes PR-Time-To-Merge median aggregation over larger intervals
Please make sure that you follow instructions from CONTRIBUTING
Specially: