Migrate from deprecated protoc-gen-validate to protovalidate v1.0.0#124
Draft
Migrate from deprecated protoc-gen-validate to protovalidate v1.0.0#124
Conversation
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
adisuissa
reviewed
Oct 31, 2025
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
I'm a bit hesitant about these big changes as if there is some incompatibility it impact everything all at once (easy to find that it is broken, but many people won't be pleased).
Will it be possible to have the old and new protoc-gen-validators, and incrementally allow them in specific files?
I guess this may be more relevant to the Envoy code, as there's call to the validator there that may be different, but for the protos as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is using protovalidate instead of protoc-gen-validate, also updates protobuf to 29.2 as it is transitively required by protovalidate