Affinity taint toleration filters #456
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varsius
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
PhilippMatthes
approved these changes
Jan 12, 2026
| case corev1.NodeSelectorOpGt: | ||
| return exists && nodeValue > req.Values[0] | ||
| case corev1.NodeSelectorOpLt: | ||
| return exists && nodeValue < req.Values[0] |
Comment on lines
+30
to
+32
| if canScheduleOnNode(node, request.Pod) { | ||
| activations[node.Name] = 1.0 | ||
| } |
Member
There was a problem hiding this comment.
Since we're using a tanh activation function, your zero-activation would be 0.0. Zero-activation here means, it has no impact on the final result because tanh(0.0) = 0.0.
Member
There was a problem hiding this comment.
Technically, we're not too precise with the wording here. The activations map is actually a weights map which is going to be mapped to an activation by the activation function. We should rename this.
Member
There was a problem hiding this comment.
This was there before, I just came across this and wanted to leave this note.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the directory structure for filters/weighers of the pod pipeline to align with the nova and manila pipeline. Secondly, filters are added that implement the default Kubernetes behavior for hard taints, tolerations and affinities. Soft requirements regarding these behaviors, which would need to be implemented as weighers, are not included in this PR and are subject for future work.