-
Notifications
You must be signed in to change notification settings - Fork 307
[FEATURE] Provide an option to force reprocessing during update #323 #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docs/yarn.lock
Outdated
| "@algolia/requester-node-http" "5.45.0" | ||
| "@algolia/abtesting@1.3.0": | ||
| version "1.3.0" | ||
| resolved "https://registry.npmjs.org/@algolia/abtesting/-/abtesting-1.3.0.tgz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lock file changes are unexpected. We're using yarn, so by default use yarnpkg.com instead of npmjs.org. Please revert change of this file.
| #[default] | ||
| Normal, | ||
| ReexportTargets, | ||
| FullReprocess, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What FullReprocess achieves is roughly a superset of ReexportTargets, so for things that need to happen on ReexportTargets mode, they need to happen for FullReprocess too
https://github.com/search?q=repo%3Acocoindex-io%2Fcocoindex%20ReexportTargets&type=code
I think we can consider add a method UpdateMode::needs_full_export() (which returns true on both modes) and use this one in many places above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added this in the latest commit. Let me know what you think!
|
@georgeh0 so I was having problems pushing this commit due to a reason unrelated to this particular issue. I did a |
|
@georgeh0 Hey, so I decided to fix the commit issue by just expanding the scope of |
Implements new cli flag
--full-reprocessin order to invalidate cache during reexport.closes #323