Skip to content

Conversation

@prithvi-moonshot
Copy link
Contributor

@prithvi-moonshot prithvi-moonshot commented Dec 14, 2025

Implements new cli flag --full-reprocess in order to invalidate cache during reexport.

closes #323

docs/yarn.lock Outdated
"@algolia/requester-node-http" "5.45.0"
"@algolia/abtesting@1.3.0":
version "1.3.0"
resolved "https://registry.npmjs.org/@algolia/abtesting/-/abtesting-1.3.0.tgz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lock file changes are unexpected. We're using yarn, so by default use yarnpkg.com instead of npmjs.org. Please revert change of this file.

#[default]
Normal,
ReexportTargets,
FullReprocess,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What FullReprocess achieves is roughly a superset of ReexportTargets, so for things that need to happen on ReexportTargets mode, they need to happen for FullReprocess too

https://github.com/search?q=repo%3Acocoindex-io%2Fcocoindex%20ReexportTargets&type=code

I think we can consider add a method UpdateMode::needs_full_export() (which returns true on both modes) and use this one in many places above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added this in the latest commit. Let me know what you think!

@prithvi-moonshot
Copy link
Contributor Author

prithvi-moonshot commented Dec 16, 2025

@georgeh0 so I was having problems pushing this commit due to a reason unrelated to this particular issue. I did a git pull a short while ago and one of new changes it brought was this example called image-search that has a type error. In order to push this commit to my remote branch I added a # type: ignore[misc] as that was the error code the type check was showing. Now a different type error is causing the GitHub pipeline test to fail. How should I proceed as this is an unrelated issue?

@prithvi-moonshot
Copy link
Contributor Author

@georgeh0 Hey, so I decided to fix the commit issue by just expanding the scope of # type: ignore as I have seen it being used in other examples too. This commit is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Provide an option to force reprocessing during update

2 participants