45 game better websocket connexiondisconnexion #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add -dev to containers's name to differenciate dev services upgrade colima s rule to not restart if mount are correct Makefile make/colima.mk srcs/dev-docker-compose.yml
Merge branch 'game-ws-connection' into 45-game-better-websocket-connexiondisconnexion
5 tasks
rom98759
approved these changes
Jan 14, 2026
| reason: reason.toString(), | ||
| }); | ||
| upstreamWs.close(); | ||
| upstreamWs.close(code, reason); |
Comment on lines
+77
to
+91
| // showPanel(panel: 'settings' | 'game-logs' | 'game-sessions') { | ||
| // ['settings', 'game-logs', 'game-sessions'].forEach((id) => { | ||
| // const el = document.getElementById(id); | ||
| // if (el) { | ||
| // el.classList.toggle('hidden', id !== panel); | ||
| // } | ||
| // }); | ||
| // if (panel === 'game-sessions') { | ||
| // this.sessionsInterval = window.setInterval(() => this.loadSessions(), 2000); | ||
| // } else if (this.sessionsInterval) { | ||
| // clearInterval(this.sessionsInterval); | ||
| // this.sessionsInterval = null; | ||
| // } | ||
| // } | ||
|
|
| <div class="bg-white/10 backdrop-blur-lg rounded-lg p-4 max-w-2xl mx-auto"> | ||
| <div class="flex justify-around text-white"> | ||
| <div class="text-center"> | ||
| <p class="text-sm text-purple-300">Player 1</p> |
Collaborator
There was a problem hiding this comment.
Mettre le nom des joueurs ?
codastream
requested changes
Jan 15, 2026
Owner
codastream
left a comment
codastream
left a comment
There was a problem hiding this comment.
cool pour le dockerfile dev
est-ce qu;on peut faire en sorte que les PR a partir de maintenant n'ajoutent pas de lints ESLint ? (on peut typer autrement qu'avec any, enlever les variables non utilisées, utiliser const plutôt que var et si possible que let
Owner
There was a problem hiding this comment.
| }; | ||
| } | ||
|
|
||
| export async function webSocketConnect(this: FastifyInstance, socket: any, req: FastifyRequest) { |
Owner
There was a problem hiding this comment.
ws fournit un type WebSocket ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebSocket connexion and disconnection are better handled: