improve code quality and boid neighbours#1
Open
chriba wants to merge 1 commit intocodatproduction:masterfrom
Open
improve code quality and boid neighbours#1chriba wants to merge 1 commit intocodatproduction:masterfrom
chriba wants to merge 1 commit intocodatproduction:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with your latest project, I made some quick fixes to improve the code quality.
Besides that, when creating the boids, I removed the boid itself when handing the neighbors over. With this improvement, we no longer need to check against itself when calculating boid movement.