Skip to content

Conversation

@tashifkhan
Copy link
Contributor

Added a Context for themes right now it has 4 theme combination

#26

const themes = {
  darkBlue: {
    "--bg-color": "#141c23",
    "--primary-color": "#232e39",
    "--accent-color": "#7ec3f0",
    "--text-color": "#eaf6fb",
    "--card-bg": "#1b232b",
    "--label-color": "#7b8a99",
  },
  white: {
    "--bg-color": "#ffffff",
    "--primary-color": "#f1f5f9",
    "--accent-color": "#3182ce",
    "--text-color": "#191c20",
    "--card-bg": "#f8fafc",
    "--label-color": "#555",
  },
  cream: {
    "--bg-color": "#fdf6e3",
    "--primary-color": "#f5e9da",
    "--accent-color": "#A47551",
    "--text-color": "#3b2f1e",
    "--card-bg": "#f7f1e1",
    "--label-color": "#555",
  },
  amoled: {
    "--bg-color": "#000000",
    "--primary-color": "#111111",
    "--accent-color": "#00bcd4",
    "--text-color": "#e0e6ed",
    "--card-bg": "#181818",
    "--label-color": "#b0b3b8",
  },
};
image
  • Used local storage to make theme persistent


Added a Proper Desktop View / Layout

image

Additional Features

image

@tashifkhan
Copy link
Contributor Author

added mock data for a guest login type showcase thingy

@codeblech
Copy link
Owner

@codelif please do sumn my ahh done become a corporate majdoor can't review nothing

@codelif
Copy link
Collaborator

codelif commented Jul 19, 2025

Will do

@tashifkhan
Copy link
Contributor Author

guys quick question shd i add auto generate timetable using the subjects and the acdemics details here
like using query parameters and like render the timetable website in an iframe

@tashifkhan
Copy link
Contributor Author

tashifkhan commented Jul 22, 2025

umm something like this maybe
https:/jportal-testing.vercel.app/#/timetable

it will pass the subjects and all the details as query params and fills the form all automatially

@codeblech
Copy link
Owner

yeah it's a good idea ... just that the design is very different from jportal. and the navbar is becoming cluttered. maybe we can move the profile button to the top near the logout button ...

@codeblech
Copy link
Owner

there seem to be performance issues in switching between routes from the navbar .. especially on the time table route

@tashifkhan
Copy link
Contributor Author

vesse honestly was thinking the same thing with the theme not matching... i think i an idea regarding this lets see if i can pull that off or not

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive theming engine with multiple preset themes and community theme support, along with significant UI/UX improvements and additional features.

  • Added a complete theming system with 4 built-in themes (Dark Blue, White, Cream, AMOLED Black) plus custom theme creation
  • Implemented community theme sharing system with static manifest generation for user-contributed themes
  • Added new features including GPA calculator, attendance sorting, improved desktop layout, and enhanced Material UI components support

Reviewed Changes

Copilot reviewed 36 out of 38 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
theme-contribution.md Documentation for community theme contribution guidelines and format specification
jportal/vite.config.js Build-time plugin to generate theme manifest from user configs and HTTPS dev server configuration
jportal/src/main.jsx Integration of ThemeProvider wrapper around the main App component
jportal/src/lib/utils.js Utility functions for decimal formatting and localStorage-based decimal place preferences
jportal/src/index.css Custom CSS for theme-aware slider components with CSS variable support
jportal/src/components/ui/*.jsx Updated UI components to use CSS variables for theming and consistent border radius
jportal/src/components/ThemeProvider.jsx Core theming system with context, localStorage persistence, and Material UI integration
jportal/src/components/ThemeSwitcher.jsx Complete theme management interface with import/export and community theme support
jportal/src/components/*.jsx Major UI overhaul with theme support, improved layouts, and enhanced functionality
Files not reviewed (1)
  • jportal/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)

jportal/src/components/AttendanceCard.jsx:1

  • There's a typo in the comment: 'alwasy' should be 'always'.
import React, { useState, useRef } from "react";

jportal/src/components/Profile.jsx:1

  • The magic number 101 used for sorting subjects with no attendance data should be defined as a named constant to improve code readability and maintainability.
import React, { useState, useEffect } from "react";

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

tashifkhan and others added 2 commits September 28, 2025 12:00
error handling for cert file missing

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants