-
Notifications
You must be signed in to change notification settings - Fork 5
Theming engine + Additional Features #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
added mock data for a guest login type showcase thingy |
|
@codelif please do sumn my ahh done become a corporate majdoor can't review nothing |
|
Will do |
|
guys quick question shd i add auto generate timetable using the subjects and the acdemics details here |
|
umm something like this maybe it will pass the subjects and all the details as query params and fills the form all automatially |
|
yeah it's a good idea ... just that the design is very different from jportal. and the navbar is becoming cluttered. maybe we can move the profile button to the top near the logout button ... |
|
there seem to be performance issues in switching between routes from the navbar .. especially on the time table route |
|
vesse honestly was thinking the same thing with the theme not matching... i think i an idea regarding this lets see if i can pull that off or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a comprehensive theming engine with multiple preset themes and community theme support, along with significant UI/UX improvements and additional features.
- Added a complete theming system with 4 built-in themes (Dark Blue, White, Cream, AMOLED Black) plus custom theme creation
- Implemented community theme sharing system with static manifest generation for user-contributed themes
- Added new features including GPA calculator, attendance sorting, improved desktop layout, and enhanced Material UI components support
Reviewed Changes
Copilot reviewed 36 out of 38 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| theme-contribution.md | Documentation for community theme contribution guidelines and format specification |
| jportal/vite.config.js | Build-time plugin to generate theme manifest from user configs and HTTPS dev server configuration |
| jportal/src/main.jsx | Integration of ThemeProvider wrapper around the main App component |
| jportal/src/lib/utils.js | Utility functions for decimal formatting and localStorage-based decimal place preferences |
| jportal/src/index.css | Custom CSS for theme-aware slider components with CSS variable support |
| jportal/src/components/ui/*.jsx | Updated UI components to use CSS variables for theming and consistent border radius |
| jportal/src/components/ThemeProvider.jsx | Core theming system with context, localStorage persistence, and Material UI integration |
| jportal/src/components/ThemeSwitcher.jsx | Complete theme management interface with import/export and community theme support |
| jportal/src/components/*.jsx | Major UI overhaul with theme support, improved layouts, and enhanced functionality |
Files not reviewed (1)
- jportal/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)
jportal/src/components/AttendanceCard.jsx:1
- There's a typo in the comment: 'alwasy' should be 'always'.
import React, { useState, useRef } from "react";
jportal/src/components/Profile.jsx:1
- The magic number 101 used for sorting subjects with no attendance data should be defined as a named constant to improve code readability and maintainability.
import React, { useState, useEffect } from "react";
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
error handling for cert file missing Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added a Context for themes right now it has 4 theme combination
#26
Added a Proper Desktop View / Layout
Additional Features
Added Danger based attendance progress circle
Added GPA calculator add cgpa goal just like attendance goal #30
Added Attendance sorting function (also used localstoage here) Adding sorting in Attendance Section #52
Made font sizes consistent across pages make font size consistent across routes #35
Added Proper Loaders better loading(&more) animations #14
Modified the cards layout add a subtle bg to make it look more pleasing to the eye