Skip to content

Conversation

@tashifkhan
Copy link
Contributor

This pull request introduces support for fee summary and fines data in the app, along with an upgrade to the jsjiit library. The main changes include adding the Fees component and route, managing fee-related state, and fetching fee summary and fines after authentication. Additionally, the jsjiit dependency has been updated to the latest version.

Fee management and display:

  • Added a new Fees component and corresponding route (/fees) to the app, allowing users to view fee summary and fines. [1] [2]
  • Introduced feesData state in AuthenticatedApp to manage fee-related data.
  • After user authentication, the app now fetches and logs fee summary and pending fines using the portal API, handling cases where no fines are found.

Dependency update:

  • Upgraded the jsjiit library from version 0.0.20 to 0.0.22 in both App.jsx and Login.jsx for improved stability and new features. [1] [2]

@tashifkhan
Copy link
Contributor Author

draft 1 ui
image

in this heavy changes required
image

need to figure out where to add this

@codeblech
Copy link
Owner

is this still draft or merge-able?

@tashifkhan
Copy link
Contributor Author

it's merage able just that placement of this tab we need to decide

@tashifkhan
Copy link
Contributor Author

like I have added the /fees route but in the app there is no redirect to it was thinking keeping it in the navbar would be too much clutter so ya

@codeblech
Copy link
Owner

yeah the navbar doesn't have any more space left

@tashifkhan
Copy link
Contributor Author

ya thats what i was thinking... that's y i had it in a draft. need to think where to link this page

@tashifkhan
Copy link
Contributor Author

can do one thing tho in the profile section we add a fines tab which will only have the fines that's levied on ya

i mean imo fees things is mostly not that imp or something you'd want to check

but fines on the other hand is something to check

so we can implement a flow in which we have a tab in the profile section for fines and maybe a link to a dedicated fees page or something or just skip the fees section entirely because not that useful info there

@tashifkhan
Copy link
Contributor Author

how about this ? @codeblech

image image

@codeblech
Copy link
Owner

yeah this is good

@tashifkhan
Copy link
Contributor Author

Resolved the merge conflicts and raised another pr for this

@codeblech
Copy link
Owner

yo, we can merge this once the conflicts are resolved. this ui looks cool

@tashifkhan
Copy link
Contributor Author

ya we can close the one and merge #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants