Improvements for working with DataScript #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboost
previously approved these changes
Jan 11, 2026
Tests cover: - deref-at: accessing historical versions of data - materialize-shallow: shallow materialization protocol - ISlot implementations for read-only types - reset! with ISlot values - nil storage as Tag/NONE - read-only types returning in-memory data for write operations - ArrayList handling for other List implementations Co-authored-by: Claude <noreply@anthropic.com>
codeboost
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few improvements so xitdb-clj can work better with DataScript:
java.util.Listimplementation to be written to the db as an ArrayList. Sometimes the DataScript data contains ajava.util.Arrays$ArrayListfor some reason, which caused xitdb-clj to throw an error.deref-atfunction to allow viewing past versions of the database and implements-slotfor the read-only types so we can easily revert to old versions of the database.Tag/NONE. Previously we were storing nils as a byte array with a format tag ofnlwhich really wasn't necessary since there is a "native" tag type for nil in xitdb.