Open
Conversation
Upgrade jna, groovy and gradle
janhoy
commented
Nov 24, 2020
| case 180: return D180; | ||
| case 270: return D270; | ||
| default: | ||
| throw new IllegalArgumentException("Allowed VipsAngle's are [0°, 90°, 180°, 270°]."); |
Author
There was a problem hiding this comment.
There was some ASCII encoding error for these characters on my mac, so I removed them
janhoy
commented
Nov 24, 2020
janhoy
commented
Nov 24, 2020
| then: | ||
| tinted != null | ||
| println tinted | ||
| def dest = Paths.get("/Volumes/HD/backups/images/${colorName}.png") |
Author
There was a problem hiding this comment.
This test failed due to hardcoded file path
…e library paths on different systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
vips_tiffsave()), including the Pyramid TIFF format. All options from libvips are supported.JLIBVIPS_LIB_PATHandJLIBVIPS_GLIBC_PATHI have tested these options from my own application:
tile,tileHeight,tileWidth,compression(JPEG),qualityandpyramid. Other options could still have bugs.Have not added any new unit tests as I'm unfamiliar with the test framework.
I find it strange that running the normal build requires PGP passphrase. I'd like to report it as an issue, but the issue tracker is not enabled on this project :(